Pranshu Srivastava
Pranshu Srivastava
`markdownlint-cli2` wasn't able to lint the compatibility matrix, owing to which the [padding logic](https://github.com/kubernetes/kube-state-metrics/pull/2325/files#diff-977ea6224b30c391b77b0ecc744af01f21bc3e813351e5cedc5f5d58f534fe84) would differ before and after the substitution or insertions were performed there. So running a linter...
Adding more context to error messages may undo some of the work done in https://github.com/kubernetes-sigs/metrics-server/pull/774. Maybe the request here is for a [more verbose](https://pkg.go.dev/k8s.io/klog/[email protected]/internal/verbosity) logging support (triggered by `-v` flags,...
Seems like a good first issue, thank you for reporting (and all the details)!
> Also we have Validate() methods in pkg/apis/monitoring/{v1beta1,v1alpha1} packages but they don't seem to be used anywhere 🤔 IIUC they seem to be used in `checkInhibitRules`. https://github.com/prometheus-operator/prometheus-operator/blob/175887b844dd5a8818cc84704585933fdbefc385/pkg/alertmanager/operator.go#L1649-L1655
> I realize that there are more fields referring to label names that would need the same validation (e.g. InhibitRule, GroupBy). Pushed a commit for `checkInhibitRule` (which uses `Validate` internally)....
Blocked by #6023.
Working on this.
Ah, I see. I guess I'll wait it out then, thanks for the heads up!