Pranshu Srivastava comments

Results 524 comments of


                                            Pranshu Srivastava

Allow all labels/annotations for resources

/assign I'd like to take this up!

do not create annotation and label metrics if none are allowed

I'm not sure about removing the default behaviour TBH. I don't see what we stand to gain if such a check is implemented? Is the effort worth the outcome?

Handle singular labels in allowlist

cc @dgrisonnet @mrueg

I just looked at the e2e suite, and it seems we are already doing this: https://github.com/kubernetes/kube-state-metrics/blob/master/tests/e2e/main_test.go#L78-L95 ([`CheckMetrics`](https://github.com/prometheus/prometheus/blob/main/cmd/promtool/main.go#L718))?

CRD metric with wrong 'kind' - pod can't start

I think the binary should error out and exit if any of the user-supplied flags entail unexpected values, unless of course, keeping them optional makes sense. The fact that a...

All kubectl logs are shown as 'stderr'

Hello @bhaskarpalani. If it's alright, could you please post the logs and the exact command you ran as well, just so I could get a better idea around this?

Deprecate VPA

Moved to v3, ready for review.

Incorporate Cobra

Ready for review.

Support filtering label allowlist by "all"