Damián Suárez
Damián Suárez
I've tested the PR and it works pretty well! Nice work 🚀 Maybe getting another ✅ from other folks won't hurt.
Probably it will fix https://github.com/Automattic/jetpack/issues/25937
> The description says that the PR is only to add storybook for connected button. But looking at the changes you're doing more things, that I'm not understanding fully. The...
> > The PR is still in progress. > > Ok, so let's move it to draft mode? And remove the reviewers. This will avoid notification since it's not ready...
> Does https://github.com/Automattic/jetpack/blob/master/projects/plugins/jetpack/extensions/README.md#upgrades-for-jetpack-sidebar-extensions need updating? I've read that section it seems to be ok from my PoV. I can add more info about these changes. > I'm not very clear...
> If I understand it correctly, we already have an ordered list of things to register in `projects/plugins/jetpack/extensions/index.json`. Correct. >The problem is that since #20944 it's now putting all the...
> > Could it get a little bit confusing? How do we deal with beta, experimental, no-post-editor extensions? > > How would you deal with those in the context of...
> Speaking of which, this PR seems to be adding the two plugins to the no-post-editor bundle where they weren't there before. Is that intended? No, it shouldn't. Let me...
> I think the change we're making to `done` makes the post dirty, so if I publish a post and then click to leave the editor I get the warning...
> If I reload the editor after publishing the post, then the networks become disabled. > That's sort of good, as it can't be shared, but I'm not sure if...