Damián Suárez

Results 58 comments of Damián Suárez

> I think at minimum, the option should at least be discoverable even if it is announced as disabled. 💯 sgtm

> > Could we have a quick design check on the styling for the disabled options? > > I'd want to defer to best practices here. At a glance the...

Thanks, Joen > An alternative is to keep the blue selection style, but instead show a semi-transparent white text-color for the disabled item when it's selected — my instincts would...

> An alternative is to keep the blue selection style, but instead show a semi-transparent white text-color for the disabled item when it's selected https://github.com/WordPress/gutenberg/assets/77539/ec4ec756-62dd-469f-849a-e78271a845f3

Hi, James. Thanks for your input. > In a lot of Combobox examples I see, disabled options do tend to lighten the background as well as the text. Could you...

> The example I looked at earlier was [this one](https://citizensadvice.github.io/react-combo-boxes/combo_box/disabled_option/index.html). There are more [here](https://designsystems.surf/components/combobox). 👍 > Generally disabled options don't share a background treatment with enabled ones. Oftentimes disabled options...

> One small tweak to the mockup above, we might apply `cursor: default` to the disabled option, to further illustrate the option is not selectable to mouse users. This matches...

> Oh is that necessary? I think I'd expect the hover and highlight (via keyboard) visuals to match. This approach, in my view, is not just good but possibly the...

item selected | disabled item focused -------|-------- |

> Seems in a good spot to me :) Thanks for your help. Super valuable. Let's wait for the other 👍s!