Peter Stenger
Peter Stenger
+1 on tanstack. I have had a great experience with it in the past.
We discussed on 12/1 that we should probably defer this to when we discuss CSV roster sync and the ability to have 'system removed users'.
1) -- this is allowed due to `(2)` 2) -- Technically, the behavior of `path.join` means that this isn't an issue. ``` path.join('/my/app/base', '/etc/passwd') /my/app/base/etc/passwd ```
Related to https://github.com/PrairieLearn/PrairieLearn/issues/11560
> > Related to [#11560](https://github.com/PrairieLearn/PrairieLearn/issues/11560) > > Can you elaborate? I believe this is a different problem. Both are related to skipping grading; this is at the question level, whereas...
@coderabbitai pause
I'm very confused by the container build behavior. I get a 4% bump without adding any `dependencies`, only `devDependencies`. I am surprised that adding `knip` bumps this by 4%, unless...
https://knip.dev/reference/related-tooling#circular-dependencies -- knip doesn't detect circular dependencies (so we can't remove depcruise), but missing packages may be covered by both depcruise and knip. I'm not too concerned about that.
Done in 2202ab4535d52f5943f8adac1fe031d24a79c41b.
It looks like `vite-node` was the culprit. In [36afb2d](https://github.com/PrairieLearn/PrairieLearn/pull/12621/commits/36afb2da443ca3ef3165869719c1652890121050) I exclude `vitest.config.ts` and `eslint.config.mjs` from analysis. Additionally, https://pkg-size.dev/knip shows that it shouldn't exceed 11MB (35MB minus typescript). So something else...