Peter Stenger

Results 209 comments of Peter Stenger

If I was recreating this element: - Add a `v="2"` attribute - These attributes would stay the same: `answers-name` `weight` `inline` - Change `fixed-order` to `order` to mirror other elements....

@jonatanschroeder The v="2" would be more helpful for documentation than actual implementation. With so many different fields, it would be nice to present a tabbed interface "here is the old...

Thanks for the feedback @nwalters512 @jonatanschroeder . I see how the `v="2"` property wouldn't be useful. In this case, we can map the old properties to new properties. I do...

I think I didn't communicate what I meant by backwards-incompatible change: I meant that if we need to introduce one, we would add a new version. I never want to...

More related to the actual PR, can we split the changes up from https://github.com/PrairieLearn/PrairieLearn/pull/10524#issuecomment-2840906711 into smaller PRs that are easier to review?

> Do you have other examples of potential backwards-incompatible changes you think we'd want to make that would benefit from versioning? I find it more helpful to talk about specifics;...

> If I was recreating this element: > > * Add a `v="2"` attribute Ignore > * These attributes would stay the same: `answers-name` `weight` `inline` Ignore > * Change...

Hmm, I didn't mean to do that...

Closing in favor of https://github.com/PrairieLearn/PrairieLearn/pull/10524. @eliotwrobson wanted a cleaner commit history.

Do we typically point at examples of extensions in the element documentation?