Corbin McNeely-Smith comments

Results 40 comments of


Corbin McNeely-Smith

Bazel@HEAD CI failing for rules_kotlin

Will bump version and see if that fixes.

Bazel@HEAD CI failing for rules_kotlin

No longer failing: https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/2657

Avoid passing kapt args to kotlinc unless outputs are provided

Apologies! I missed this pr. @jongerrish Have a gander?

Add support for javac KAPT arguments

Apologies for the delay. Quick question: how often is the toolchain args used vs. rule args?

Parameter 'output_jar' is deprecated and will be removed soon

Probably deprecated. I'll take a look.

Automated Nightly Releases

Open issue in the bazel repo to set this up for us.

Automated Nightly Releases

We need to sort out pulling artifacts from BuildKite to make "nightly" (TBH, there aren't enough PRs to be truly nightly) work. Mostly because I'd rather avoid running out Github...

Change loading rules_kotlin to avoid a three stage loading for declared versions

Option: - Ship separate release for kotlin versions

add test for sealed class

Repro for https://github.com/bazelbuild/rules_kotlin/issues/638

Can't use rules from head without bazel installed.

I presume you are not running this from a release? The work around is to run: ``` bazelisk build //:rules_kotlin_release mkdir /tmp/rules_kotlin_release && tar -xvf bazel-bin/rules_kotlin_release.gz -C /tmp/rules_kotlin_release ``` And...