Corbin McNeely-Smith comments

Results 40 comments of


Corbin McNeely-Smith

rules_kotlin should link the embeddable Kotlin compiler

I looked into just using the embeddable compiler (available from Maven) It's doable, but comes with some awkward api changes: * `com_github_jetbrains_kotlin` would be removed -- Not against this, as...

rules_kotlin should link the embeddable Kotlin compiler

Reopening as a feature request.

`kt_android_library` cannot depend on a cc_library

Temporary workaround is to wrap `:jni_lib` in a `java_library`

Release rules_kotlin as a Bazel module

> 1. Move kt_jvm_import (and kt_js_import) targets from the kotlin_complier repository into the rules_kotlin repository (just export files instead from kotlin_complier repo) to break dependency edge from compiler repo to...

Add kotlin-reflect on the builder classpath

> @cgruber @restingbull We are running into this issue internally. Are there any concerns with merging this PR. Yes -- the classpath for the builder shouldn't be part of the...

Add kotlin-reflect on the builder classpath

> > > @cgruber @restingbull We are running into this issue internally. Are there any concerns with merging this PR. > > > > > > Yes -- the classpath...

Does KSP require a separate runner?

KSP Task Runner: https://github.com/google/ksp/blob/42217b8cbf11609d42eee71a607e4011904c6cd8/gradle-plugin/src/main/kotlin/com/google/devtools/ksp/gradle/KspAATask.kt#L72

Does KSP require a separate runner?

Bazel OOMs during analysis phase when KSP provides Java outputs information

TODO: * do we still need the aspect? * Clean up provider structure.

Implement Jdeps using K2 APIs

This generally looks fine, but I would prefer to wait until the dependencies are out of RC. Additionally, we have some concerns about backwards compatibility -- I am looking to...