Renaud Chaput

Results 390 comments of Renaud Chaput

I started researching this yesterday and the big blocker is `redis-namespace` support being dropped. We need a clear migration path to avoid phantom jobs and will be hard to properly...

Another potential issue here is the removal of `hiredis` for Sidekiq, we will need to test this in a high-load environment to test how it performs, but if this means...

The redis question is a bit more complex. Currently we do not support complex Redis setups, for example with TLS (mandatory for some hosted Redis offerings) or distributed Redis setups...

The main task here seems to be the migration path for servers with a namespaced Redis configuration. This seems doable, but will require an extensive documentation about the steps. What...

An issue with using Redis databases: redis pub/sub (used for streaming) does not support databases: https://redis.io/docs/interact/pubsub/#database--scoping The documentation advises to add a scope in the front of the keys, similar...

This seems correct. I am very open to update to Sidekiq 7 in the 4.3 release, but we need to figure out the proper migration path for people using namespaces.

Please refrain from pinging people on your PRs. We have very limited resources, and spamming wont really help you here.

This is a very reasonable expectation, but unfortunately we are very short on resources and the whole team (Eugen especially) has a lot to do, so I am afraid we...

> I think this is now good for review, and hopefully merge in to main for 4.3 (with possibly backporting) We generally do not backport features, except if they are...

Tests are failing after this change, looks like it changes the types on the ruby side from integers to floats?