Renaud Chaput

> This works for now, but if possible, it is probably better to define `History.LocationState` globally to be `MastodonLocalState | undefined`, which I have not managed to do (I am...

Rails 7.1 is now released 🎉 https://github.com/rails/rails/releases/tag/v7.1.0

You will need to update the `@rails/ujs` JS package as well

> I think this should not run systematically on the CI given the additional cost, and be optional for development given the additional requirements. This should also have minimal impacts...

`rails spec:system` runs the system tests, but I am not sure how to ignore them in `rails spec`. This will probably require overriding this rake task to add `exclude_pattern: 'spec/system/**/*`,...

PR status: - Automatically starting the streaming server before the first system spec is launched works fine, and it is shutdown when the test suite ends - Specs use an...

Regarding your roadmap, I would like system tests to be in place asap, as we are doing some heavy frontend refactor (touching major libs like the router) and it is...

Recent changes: - Removed the `LOCAL_DOMAIN` changes, system tests work fine without it. But it would still be better to use a proper domain name for those. - Removed `unsafe-eval`...

> The "feature specs" in rspec pre-date Rails having a built-in solution, but required you to do some manual setup on the capybara/transaction/database_cleaner side. In some rails release, "system tests"...

All comments above have been addressed, except the part about how the specs are organised (system vs feature) and how the helpers are organised (it still reuses the existing stories...