Renaud Chaput
Renaud Chaput
> you shouldn't need two different dockerfiles, no? just potentially a multi-stage build with the webpack step occurring in the build platform arch, and the final copying happening in the...
I think that you can do it using https://github.com/docker/setup-buildx-action, they have a section about configuring external builders. But if the Webpack build is done only on the native platform, I...
> Asset compilation is (for reasons unknown to me, I'm not a ruby ecosystem connoisseur) single-threaded, so at most you may be parallelizing some other steps but the bottleneck won't...
@jippi Thanks a lot for your work on this. Do you think you can optimise the build further? If you think this is ready for review, could you clean up...
> It makes sense to bundle its own `streaming/package.json`. I've did a quick research, by extracting it's dependencies: This is our plan, once 4.2.0 is released.
There is already a PR for splitting the streaming server: https://github.com/mastodon/mastodon/pull/24702 As said above, we will work on merging this once 4.2.0 is released (in a couple of weeks hopefully).
This is a `kt-paperclip` bug, from this line: https://github.com/kreeti/kt-paperclip/blob/91923a6ee1bd692696b51ea839f2f2578cb485b4/lib/paperclip/file_command_content_type_detector.rb#L18
> I'm not sure how to spot them short of carefully reading _all_ the tests… Could we merge the codecov PR first, then compare the coverage?
There must be an issue with Covecov, as the page for this PR looks very wrong: https://app.codecov.io/gh/mastodon/mastodon/pull/25369/commits
Closing as this should be solved by the new hashtag bar. Hashtags that are on a single line at the end of a post are now moved to the hashtag...