Renato Costa
Renato Costa
> Hi @renatolabs, thanks for your submission! Please could I get you to add a change log entry ([https://github.com/hashicorp/vault/blob/main/CONTRIBUTING.md#changelog-entries](https://github.com/hashicorp/vault/blob/main/CONTRIBUTING.md?rgh-link-date=2022-09-07T13%3A42%3A47Z#changelog-entries))? Done, thank you for the reminder!
> Seems like the test failures are not flukes. I'm able to reproduce them when running the pull-request locally with `make test`. I'd be ok to approve the changes if...
I suppose this is related to this section ```go // There is always one nil seal. We need to skip it so we don't start an empty Finalize-Seal-Shamir // section....
> > But I'll let folks with more knowledge of the codebase to weigh in; let me know if you want me to any changes here! > > Well, I...
bors r=srosenberg,erikgrinaker TFTR!
Note that this does not guarantee that no errors are seen when running the `rand` workload. One issue I observed in my tests is that random data generation is not...
bors r=smg260 TFTR!
@smg260 I pointed a couple of misplaced comments on https://github.com/cockroachdb/cockroach/pull/88556. Maybe we could fix those here?
This change introduced a data race on `TestConsumeJoinToken` (https://github.com/cockroachdb/cockroach/issues/85988). I'm going to create a PR shortly to skip that test under race for the time being. Edit: PR to skip...
Duplicate of #119511.