cockroach icon indicating copy to clipboard operation
cockroach copied to clipboard

Published 20 hours ago • verified publisher icon cockroachdb

insights: ingester

Open matthewtodd opened this issue 2 years ago • 1 comments

Closes #81021.

Here we begin observing statements and transactions asynchronously, to avoid slowing down the hot sql execution path as much as possible.

Release note: None

matthewtodd avatar Jul 29 '22 21:07 matthewtodd

This change is Reviewable

cockroach-teamcity avatar Jul 29 '22 21:07 cockroach-teamcity

bors r+

matthewtodd avatar Aug 11 '22 15:08 matthewtodd

Build succeeded:

craig[bot] avatar Aug 11 '22 17:08 craig[bot]

This change introduced a data race on TestConsumeJoinToken (https://github.com/cockroachdb/cockroach/issues/85988). I'm going to create a PR shortly to skip that test under race for the time being.

Edit: PR to skip the test: https://github.com/cockroachdb/cockroach/pull/85989.

renatolabs avatar Aug 11 '22 19:08 renatolabs

This PR is also introducing a consistent data race in my PR that was ready to merge until I rebased onto this. Should we revert this PR, as it seems to be exposing the codebase to data races? My data race stack also points to https://github.com/cockroachdb/cockroach/issues/83080

msbutler avatar Aug 11 '22 20:08 msbutler

I've just sent #85994 to disable this problematic codepath until I can get to the bottom of it. I'm sorry for the disruption!

matthewtodd avatar Aug 11 '22 20:08 matthewtodd

thanks!

msbutler avatar Aug 11 '22 21:08 msbutler