Results 34 issues of Rémi

Automated update of upstream public suffix list

PR: Update PSL :scroll:

Hi, This is a first attempt to fix issue #8 by providing a pylint checker. I hope this can help! Rémi

Hi, Since `"` and `'` are considered punctuation in English, I thought it would be a good idea to add this characters in the function `strip_punctuation!` in the `preprocessing` module....

One nice addition to the project would be to have a GitHub workflow to run on pull requests. This workflow could install the required dependencies and compile the project with...

good first issue

There are a few resources we might be able to leverage to test more corner cases for the parsing logic. * https://github.com/cweb/url-testing/blob/master/urls.json * https://webkit.org/blog/7086/url-parsing-in-webkit/ * https://www.lookout.net/test/url/ * https://www.lookout.net/test/url/url-runner.html

`browser/app/profile/firefox.js` Default value for `MOZ_SERVICES_SYNC` is set to False here: `browser/moz.configure` https://github.com/cliqz-oss/browser-f/blob/master/mozilla-release/browser/moz.configure#L9 => `imply_option('MOZ_SERVICES_SYNC', False)` Look for: `#ifdef MOZ_SERVICES_SYNC` and `%ifdef MOZ_SERVICES_SYNC`, found following files (in `mozilla-release` folder): * `modules/libpref/init/all.js`...

require decision
diffspection

`modules/libpref/init/all.js` (prefs starting with `geo.`) https://github.com/ghostery/user-agent-desktop/blob/8f59bd745702f7c76f97bc3d67472577824ac644/modules/libpref/init/all.js#L4040 https://github.com/ghostery/user-agent-desktop/blob/8f59bd745702f7c76f97bc3d67472577824ac644/modules/libpref/init/all.js#L4058 https://github.com/ghostery/user-agent-desktop/blob/8f59bd745702f7c76f97bc3d67472577824ac644/modules/libpref/init/all.js#L4067

diffspection

`browser/app/profile/firefox.js` https://github.com/cliqz-oss/browser-f/blob/master/mozilla-release/browser/app/profile/firefox.js#L169 ```js // If set to true, the Update Service will attempt to use Windows BITS to // download updates and will fallback to downloading internally if that fails....

os: windows
diffspection

`browser/components/BrowserGlue.jsm` https://github.com/cliqz-oss/browser-f/blob/master/mozilla-release/browser/components/BrowserGlue.jsm Jira: https://cliqztix.atlassian.net/browse/DB-2313 PR: https://github.com/cliqz-oss/browser-f/pull/1456

os: windows
diffspection

Replace `Mozilla` with `Ghostery`? Do we need that? `widget/windows/WinTaskbar.cpp` `widget/windows/nsWindowDefs.h`

branding
os: windows
diffspection
upstream