user-agent-desktop icon indicating copy to clipboard operation
user-agent-desktop copied to clipboard

Disable Firefox Sync

Open remusao opened this issue 5 years ago • 3 comments

browser/app/profile/firefox.js

Default value for MOZ_SERVICES_SYNC is set to False here: browser/moz.configure https://github.com/cliqz-oss/browser-f/blob/master/mozilla-release/browser/moz.configure#L9 => imply_option('MOZ_SERVICES_SYNC', False)

Look for: #ifdef MOZ_SERVICES_SYNC and %ifdef MOZ_SERVICES_SYNC, found following files (in mozilla-release folder):

  • modules/libpref/init/all.js
  • toolkit/profile/content/profileDowngrade.xhtml
  • toolkit/modules/AppConstants.jsm
  • browser/app/profile/firefox.js
  • browser/installer/package-manifest.in
  • browser/themes/osx/jar.mn
  • browser/themes/windows/jar.mn
  • browser/modules/PageActions.jsm
  • browser/themes/linux/jar.mn
  • browser/locales/jar.mn
  • browser/components/customizableui/CustomizableWidgets.jsm
  • browser/components/customizableui/CustomizableUI.jsm
  • browser/components/customizableui/content/panelUI.inc.xhtml
  • browser/components/BrowserGlue.jsm
  • browser/base/jar.mn
  • browser/base/content/browser-menubar.inc
  • browser/base/content/nsContextMenu.js
  • browser/base/content/browser.xhtml
  • browser/base/content/browser-places.js
  • browser/base/content/browser-doctype.inc
  • browser/base/content/tabbrowser.js
  • browser/base/content/browser-sidebar.js
  • browser/base/content/browser.js
  • browser/base/content/browser-pageActions.js

browser/base/content/browser.xhtml https://github.com/cliqz-oss/browser-f/blob/master/mozilla-release/browser/base/content/browser.xhtml#L1165

browser/components/customizableui/content/panelUI.inc.xhtml https://github.com/cliqz-oss/browser-f/blob/master/mozilla-release/browser/components/customizableui/content/panelUI.inc.xhtml#L235

browser/themes/osx/preferences/preferences.css https://github.com/ghostery/user-agent-desktop/blob/8f59bd745702f7c76f97bc3d67472577824ac644/browser/themes/osx/preferences/preferences.css#L73

browser/themes/linux/preferences/preferences.css https://github.com/ghostery/user-agent-desktop/blob/8f59bd745702f7c76f97bc3d67472577824ac644/browser/themes/linux/preferences/preferences.css#L35

remusao avatar Sep 11 '20 13:09 remusao

This looks like a hard disable. At the moment we do a soft disable via pref: https://github.com/ghostery/user-agent-desktop/blob/204e9a987886c4d41ed34acc68f6d608ff2e5b48/brands/ghostery/branding/pref/firefox-branding.js#L115

This has the advantage is that advanced users who want to use Firefox sync can re-enable it (requires a restart). Disabling at build time probably excludes sync components entirely. We should decide if we want to go with a hard or soft disable.

sammacbeth avatar Sep 24 '20 15:09 sammacbeth

Let's park this one on a roadmap

chrmod avatar Sep 24 '20 17:09 chrmod

i would love to have an option to re-enable this i run my own sync-server, with my own data-store.

cereal2nd avatar Dec 23 '22 08:12 cereal2nd