Veeck
Veeck
With my PR the weatherEndpoint is only used if explicitly set in the config, and not per default. That way existing configs still function (if at all) but new users...
Looking at the code of other providers it seems that at least darksky should have the same problem...
It might be tiny, but I still would like to test it before commiting any change. So without any darksky credentials I wont be able to do it.
Thx for the key, fixed the metric stuff in my WeatherUnitCleanup-PR but somehow darksky seems ok with the "normal" config (type), can you confirm?
Yeah, thx. Looking into the tests still since that whole done-calls are looking somehow funky...
Hi @Kayakbabe this sounds like an interesting and helpful thing. Do you have the PR already in progress or need some help?
by the way: is that a duplicate of https://github.com/MichMich/MagicMirror/issues/2880 ? can one be closed
Yes, in the long run this might be interesting for other modules as well. But I would propose to first do it in this here since @Kayakbabe seems to be...
would love to see that merged soon @MichMich if you can spare the time so that I can work on fixing bugs in my weather branch.
I think the README of the new weather module could be adjusted too