MagicMirror icon indicating copy to clipboard operation
MagicMirror copied to clipboard

Published 20 hours ago • verified publisher icon MagicMirrorOrg

E2E tests never fail

Open rejas opened this issue 2 years ago • 1 comments

When working on my weather refactoring I noticed that the E2E tests never fail.

As can be seen after this commit to the branch https://github.com/MichMich/MagicMirror/pull/2849/commits/d4ef2d157e3414ec60e0b9cdc10068ce3705176d

the test suite should obviously fail, but the checks are all green.

Not sure yet when this bug got introduced, maybe the e2e refactoring has something to do with it? @khassel do you have an idea?

rejas avatar Sep 17 '22 20:09 rejas

do you have an idea?

not at the moment, will look into this ...

khassel avatar Sep 17 '22 20:09 khassel

@rejas can this be closed? Thanks.

khassel avatar Oct 01 '22 20:10 khassel

Yeah, thx. Looking into the tests still since that whole done-calls are looking somehow funky...

rejas avatar Oct 02 '22 07:10 rejas