Reid Barber
Reid Barber
It should be getting called. Here's a working codesandbox: https://codesandbox.io/s/react-aria-switch-example-42ydb6?file=/src/App.tsx Are you able to reproduce the issue you're seeing in a codesandbox, or post a code snippet?
> I was expecting to see the underlay here, any idea why I'm not? https://reactspectrum.blob.core.windows.net/reactspectrum/350bbc19ac4cac2f9dc5400fec50b1be76caca41/storybook/index.html?path=/story/dialogtrigger--type-popover&providerSwitcher-toastPosition=bottom I only enabled in MenuTrigger and ComboBox for now to test. I can go ahead...
> LGTM, tested in Chrome, FF, Safari, Chrome Android. Just wanna make sure but the issue w/ the scrollbars showing up when these popovers are opened is a followup item/out...
The scrollbar hiding comes from here, which is also the way to prevent scrolling: https://github.com/adobe/react-spectrum/blob/c24dc2e0124fac3467b3adc48b1067f2447cd2b3/packages/%40react-aria/overlays/src/usePreventScroll.ts#L57-L64 Not sure if there's an alternative.
This seems reasonable. Not sure if there are any others we would want to include, short of extending https://github.com/microsoft/TypeScript/blob/9767f51758c2899ad09c3466fd6ebbde79f53f63/lib/lib.dom.d.ts#L6925
> @reidbarber thats weird, are you able to reproduce it consistently? I saw this happen a long while ago I think but couldn't reproduce it, I can take another look...
For a temporary workaround, you may want to add some logic that increases the z-index left thumb up when the right thumb is at the max value (and vice versa)....
@peterjcole that works too, I just made it work the same for both to be a bit safer.
> Is this something that should be working on the built version of the docs or just locally? I'm just seeing the sandboxes Working for me on the built version......
> This is pretty cool. I like the idea of making it opt-in though. I'm a bit concerned about the loading performance at the moment, seems fairly heavy. Maybe we...