Sam Reed

> Out of interest what is the browser useage of the main forum? As this would be a good guide to what browsers are being used by the users of...

> Thanks @reedy, Looks great, have you moved just the user module files as an example? Not sure that Im following the rationale for moving locale to languages? > >...

https://github.com/emoncms/emoncms/pull/890/commits/cb563b8765f1c553e7eecf3457634810683d301a doesn't apply cleanly, which is hardly a surprise after 2 years

That's everything but https://github.com/emoncms/emoncms/pull/890/commits/7b1bd4fe2df4230f4e3ee2145ffe98c028580330 cherry-picked and rebased I just noticed in https://github.com/emoncms/emoncms/pull/890/commits/8841e100d9bca821a8fff3f7f5b53335cdce3d15 that two different libraries are brought in...

> I just noticed in [8841e10](https://github.com/emoncms/emoncms/commit/8841e100d9bca821a8fff3f7f5b53335cdce3d15) that two different libraries are brought in... So probably means this stack doesn't quite work with the adding/renaming of functions...

> Thanks @reedy whats the reason for renaming _( to e( and __(? Again, ask @gablau :). I just rebased his patches. Only the composer one at the bottom of...

>In addition, the new functions are simple to use and save code: "_e(" instead of "echo _ (" PHP isn't JS/CSS where every character matters ;)

I note there's https://github.com/emoncms/emoncms/blob/master/.jshintrc but it doesn't seem to be actually used anywhere for anything...

> Could that be because the .jshintrc file is expecting global 'use strict' and double quotemarks "" which will flag up a lot of the js files? Obviously you could...

If this is moved forward, I'd highly recommend not adding the lib like this, but infact bring it in use composer https://github.com/php-gettext/Languages#with-composer Will make the diff a lot cleaner