Sam Reed

Results 294 comments of Sam Reed

> how do you apply recursively through multiple directory levels to only .php files? As I did it in https://github.com/emoncms/emoncms/pull/1585 ;) ``` phpcbf --standard=PSR2 --ignore=*/vendor/* --ignore=*/Lib/* --extensions=php . ```

I do note that the moving of the `{` from the end of a function defintion onto a new line seems pointless... Especially when they're staying on the end of...

I don't think any of the actual issues in the Codacy review are new, it's just because I'm touching the file... But yet, it's not complaining about https://github.com/emoncms/emoncms/pull/1573 ? Is...

This is the bare minimum to get it running. It'll no doubt fail, so we put rule amendments ontop :)

Filed #1586 as travis isn't running here now... But it is running in my fork See https://travis-ci.org/github/reedy/emoncms/jobs/679410625 for example failures. It gave up because of there being so many, but...

Ok, https://travis-ci.org/github/reedy/emoncms/jobs/679413070 is more representative

> Great, maybe we should fix some of these before merging this in :) I would probably concur. And/or as a seperate commit in the same tree I imagine we...

> Is this the right time to move to "php-parallel-lint/php-parallel-lint": "1.2.*" as the currently used one is marked as abandoned? It's completely unrelated, so should be a seperate patch IMHO...

> Though, this probably isn't a problem here... I'll make a patch in a bit :) Done for all repos

But we're not actively testing on these browsers anyway... So how would we necessarily know if it's broken or not? https://github.com/emoncms/emoncms/issues/1568 https://github.com/flot/flot/blob/0fd613b/README.md says >Generally, all modern browsers are supported. What...