Sam Reed

It will be runnable locally too, and for some rules, it'll have an "autofix" functionality too. You can define a set a rules for a repo, and then set exclusions...

> Could try this on some of the smaller Module repos first. Yeah, it's probably not a bad idea, especially if we're wanting to avoid big sweeping changes here for...

I don't think it's unreasonable to enforce code style as part of the CI/submission process. If it requires a human to manually review code style, you're doing it wrong. And...

The trailing whitespaces, inconsistent indenting.. among others are really starting to irk me

I would disagree. Not using braces caused major bugs in things like OpenSSL over the years. It's easier (and better IMHO) to be explicit https://blog.codecentric.de/en/2014/02/curly-braces/ The "experts" get it wrong,...

> I need to really understand what we are proposing here to progress on this. So I see PHP_CodeSniffer here: https://github.com/squizlabs/PHP_CodeSniffer and install it with > > ``` > pear...

Noting, there are many 3rd party rulesets available elsewhere, things can be configured etc There's no right answers (well, beyond consistency for example, it should be tabs or space indenting...

A slightly amusing one is [PSR-2](https://www.php-fig.org/psr/psr-2/) is deprecated in favour of [PSR-12](https://www.php-fig.org/psr/psr-12/) Personally, I'm more in favour of more whitespace where possible, it generally adds to readability, and it doesn't...

I just made #1588 for fun... (if you want to use it for reference) There's probably gonna need to be some manual fixing after some of the changes Oh, and...

I suspect, commiting a directory/handful of files at a time is a probably a better way to do it and make it easier to review