redwrasse

Support ngrams in the Tokenizer- save the user from some unnecessary ad hoc code

Understanding convolution kernels in dilation layers

4

Hi @ibab, I'm a bit late to the wavenet paper implementation party, but I'm reading the paper and your code and trying to understand where dilated convolution kernels are present....

Use make_tensor implementations of random symmetric matrix generation in common_utils

2

Use make_tensor implementations of random symmetric matrix generation in `common_utils.py` (as indicated in the TODO comments).

fileutil: improve control flow readability of purgeFile function

6

PR for issue https://github.com/etcd-io/etcd/issues/17565 Proposed improvement to syntax for control flow of `purgeFile` function in `client/pkg/fileutil/purge.go`. - go routine accesses single slice `fnamesWithSufix` that remains unmodified. - `nPurged` variable introduced...

Use errors.Is for error equality checks

17

Update `err == *` expressions to `errors.Is(err, *)`, as a preferred means of error equality checks that can handle wrapping (https://pkg.go.dev/errors#pkg-overview). This PR updates all cases to be fixed in...

Remaining errors.Is for error equality checks

8

This PR follows up on https://github.com/etcd-io/etcd/pull/18510 to replace the rest of error equality/inequality checks with `errors.Is`, which is robust to error wrapping (https://pkg.go.dev/errors#pkg-overview). @ivanvc

Updates error to follow Go convention of lowercase error strings.

tests: remaining errors.Is conversions

14

tests directory errors.Is conversions, as part of https://github.com/etcd-io/etcd/issues/18576

bcrypt: update InvalidCostError message to describe cost range inclusive

5

Updates `InvalidCostError` error string in the `bcrypt` package to present cost range bounds as inclusive (brackets []) instead of exclusive (parentheses ()).