Recep Aslantas

Results 172 comments of Recep Aslantas

Now readonly parameters are marked as `const` at https://github.com/recp/cglm/pull/86 cc @kaadmy @heapseeker

After marked readonly params as `const`, I got these warnings at Ubuntu: ```bash warning: pointers to arrays with different qualifiers are incompatible in ISO C [-Wpedantic] ``` Helpful resources: https://stackoverflow.com/questions/34488559/pointer-to-array-with-const-qualifier-in-c-c...

> Did you decide not to implement this? @Daniel-Schreiber-Mendes not exactly, just I couldn't make it in a proper way. As @hartenfels said, since struct api takes parameters as read-only,...

I’ll re-investigate this later, maybe we can find a good or cool way to make **IN** params **CONST** without breaking the existing api, for instance **mat4_const** or `vec4 * const...

@erich666 thanks for review this PR, > Thanks, and it would be helpful if you described a bit why you made these changes. It looks like a bit of cleanup,...

> I noticed that Codacy says: > Variable 'h' is assigned a value that is never used. > EulGetOrd(order, i, j, k, h, parOdd, repYes, frmR); > This would be...

> I'll wait for that addition and then give a full review @erich666 that would be perfect 🤗 > In searching, I did find this, https://math.stackexchange.com/questions/3444267/extracting-euler-angles-from-quaternion-close-to-singularity, which should interest you....

Hi @jljusten good points, > Would cglm continue to say the project license is MIT if this was merged? Or, would the project license become MIT and the EULA? The...

@erich666 many thanks for quick and detailed response, So, we can use this codes (with small modifications) in MIT-Licensed **cglm** repository by providing link to original source codes, book and...

> Oh, you meant the MIT License. Like I say, put the license where you think it makes sense. Thanks 🤗