shuting

Results 647 comments of shuting

> > I wasn't able to test this but looks like they need to provide a default `user.Info` when creating the attributes record so `request.userInfo.username` exists during CEL evaluation. >...

Hi @JagjeevanAK - thanks for the fix! I I see unit tests are added, this is good. And I wonder what's the best way to test it in a cluster?

I’m not really on board with reusing the v1alpha1 types for v1beta1. I’d rather we stick to the Kubernetes pattern where each API version gets its own Go types, even...

> Why would we want to duplicate the structs ? What we have today is not working by the way, it highlights the difficulty of maintaining parity with re-using the...

> A couple of things: > > * Kubernetes has tooling to detect non-parity > * I don't think Kubernetes has set that in stone, i remember discussing it with...

Hi @ikartiksh - can you please fix the linter failure?

The behavior of webhook configurations changes in 1.16, each validatingpolicy has its dedicate webhook rule. Please check with latest release and confirm.