Ryan Blue

Results 205 comments of Ryan Blue

> I am unsure of how to proceed for branches and tags usecase. Just making changes to read from branch/tag in SparkScanBuilder worked before for previous versions of spark -...

This looks good to me. I'm rerunning CI since the failures don't look related to this.

I think it's better to put names like this after a `:` instead of adding characters that can get copied and moved to other places. Putting names after `:` still...

> we could add the property name to the end in this particular case to have `Cannot parse from non-array value: %s: %s`. I prefer this approach to quotes. When...

@nastra, I opened https://github.com/nastra/iceberg/pull/23 to remove the old counter implementations. Let me know what you think.

I was able to remove `IntCounter` and `LongCounter` by moving `Counter.NOOP` definition into `DefaultCounter`. I think that's the main thing that we need to do to get this in.

Looks good to me. @aokolnychyi, do you want to take another look?

I think that all of the session references are to the cloned Spark session now. +1.

@aokolnychyi, is it possible to get the DataFrame API in Spark updated now that 3.5 has implementations for these plans?