Ryan Blue

Results 205 comments of Ryan Blue

Good timing. I was just extracting the system that we use in Toree to its own repository: https://github.com/rdblue/jupyter-repr-api

@gallushi, can you describe what you're suggesting in a bit more detail? How would you use atomic write instead? And how would you detect whether to use atomic write or...

@gallushi, that sounds good to me. As long as the file commit is atomic, I think we can work with it.

@gaborkaszab, what is the use case for these metrics? We haven't seen very many people actually mixing file types in a table so I'd be interested in how this is...

Yes, we do need more documentation for Hive. I think this is something I'll work on after the 0.10.0 release candidate is out.

Mostly looks good to me. I flagged a couple of minor things. Also, I don't think that we resolved this thread: https://github.com/apache/iceberg/pull/9717#discussion_r1501928527

This looks good to me now. Since we have 3 approvals, I'll go ahead and merge it.

What alternative algorithm would you suggest? The current algorithm is simple and I'm sure could be improved.

Maps with non-string keys are not allowed in Avro, but they are valid in Iceberg. That means we need to serialize `m: map` differently. The approach we take is to...

If you needed to register a logical type, then you must be using Avro's `DatumReader` instead of an Iceberg `DatumReader`. Iceberg has a set of readers for objection construction that...