iceberg icon indicating copy to clipboard operation
iceberg copied to clipboard

API: Deprecate generic Counter<T extends Number> and replace with simpler Counter API

Open nastra opened this issue 3 years ago • 1 comments

Most of the time using a non-generic Counter API with a long value is simpler, especially when it comes down to serializing/deserializing Counter results (since we'd need to know the underlying generic type as well).

Therefore we'd want to move away from Counter<T extends Number> and replace it with Counter.

nastra avatar Aug 11 '22 10:08 nastra

@nastra, I opened https://github.com/nastra/iceberg/pull/23 to remove the old counter implementations. Let me know what you think.

rdblue avatar Aug 11 '22 23:08 rdblue

I was able to remove IntCounter and LongCounter by moving Counter.NOOP definition into DefaultCounter. I think that's the main thing that we need to do to get this in.

rdblue avatar Aug 14 '22 17:08 rdblue