Ryan Linard comments

Results 7 comments of


                                            Ryan Linard

chore: Docker Compose import milestone 1 - library setup and basic service conversion

One issue that needs to be addressed after this PR - how do we handle LBWS conversion without duplicating tons of code? The LBWS manifest is almost exactly the same...

chore: Docker Compose import milestone 1 - library setup and basic service conversion

That's a good point! I think that once the Backend Service handling is fleshed out in a PR or two, the LBWS handling can be copy pasted from that, instead...

chore: Docker Compose import milestone 1 - library setup and basic service conversion

Thanks for the great feedback, that should all be addressed now!

test: add load to local integ tests

Looks like this conflicts! It does have two approvals so it'll be automatically merged once they're resolved it looks like.

chore: Allow service manifests and other YAML manifests to be successfully marshalled without losing data

> Also could you explain why we need to add `MarshalYAML`? A common pattern we have is: ```go struct StructOrString { str *string struct *struct } ``` Without MarshalYAML, this...

chore: Allow service manifests and other YAML manifests to be successfully marshalled without losing data

I've restored the removed tests & added the `parser` field back - but I've instead made it so that the `parser` field isn't required to be set, and `template.New()` will...

chore: Allow service manifests and other YAML manifests to be successfully marshalled without losing data

Thanks for the feedback! Your comment is actually partially addressed in the follow up PR - my follow up PR does some substantial reworks to our service templates to incorporate...