copilot-cli icon indicating copy to clipboard operation
copilot-cli copied to clipboard
verified publisher icon aws

test: add load to local integ tests

Open iamhopaul123 opened this issue 3 years ago • 1 comments

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

iamhopaul123 avatar Jul 22 '22 21:07 iamhopaul123

I'm having a hard time figuring out what the implications of this change are - from what I can see, calling Load might result in an EC2 API call in some cases through dynamicSubnets.load indirectly being called? Is that known/intended?

Your understanding is correct. That's exactly the reason why it was not there before. And the reason why I decided to add it back is because we want to make sure no API calls if we don't set any field that will cause API calls in the manifest (of course if in the test manifest lets say we enable from_tag then this local integ test will fail, which is expected).

iamhopaul123 avatar Jul 26 '22 16:07 iamhopaul123

Looks like this conflicts! It does have two approvals so it'll be automatically merged once they're resolved it looks like.

rclinard-amzn avatar Aug 16 '22 00:08 rclinard-amzn