Robrecht Cannoodt
Robrecht Cannoodt
I created a PR (#209) which contains a unit test for this edge case.
I think the issue occurs whenever there's a function from the HDF5 library that expects a buffer. ```c if(XLENGTH(R_buf) == 0) { buf = NULL; } else { buf =...
I managed to solve the issue by replacing the `XLENGTH(.) == 0` condition with `TYPEOF(.) == NILSXP`: ```c const void* buf; if(TYPEOF(R_buf) == NILSXP) { buf = NULL; } else...
No worries and thanks! Is there anything I can help out with? Would it help to schedule a call?
Thanks for looking into this! > this code is auto-generated It's good to hear that the code is auto-generated. I couldn't imagine maintaining this code base across different versions of...
Aha, that's what the patches are for! Makes sense :) Thanks for fixing the issue!
It seems @ycli1995 fixed https://github.com/ycli1995/hdf5r.Extra/issues/1 :relaxed: Could we get this fix merged and released? :bow:
Hi @hhoeflin! I ran a revdepcheck on this branch: > revdepcheck::revdep_check(timeout = as.difftime(600, units = "mins"), num_workers = 8) ── CHECK ───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────── 13 packages ── ✔ readNSx 0.0.2 ── E:...
Awesome, thanks!
Hi @rosanababu ! Could you post the `str.h5mu` so the package maintainers can try to replicate the issue? Robrecht