Raymond Chu

Results 114 comments of Raymond Chu

[Bug] Not all threads terminate prior to `main` when executing certain unit tests

Thanks for finding this. Since this only affects testing, I will update the label for this issue.

[Bug] empty struct causes build to fail with cryptic error message

@d0cd @evan-schott Is this still a relevant concern?

[Test] Invoke `transfer_public` with insufficient fees.

Changes to how we set minimum fees proposed here - https://github.com/AleoHQ/snarkVM/pull/1687 will invalidate this test (since this test uses the priority_fee_in_microcredits as the finalize fee payment)

[Bug] Controllable allocation size allows for memory leaks or panics (depending on size)

Closing with https://github.com/AleoNet/snarkVM/issues/2291#issuecomment-1884542664. @feezybabee feel free to reopen if the original author has any additional information.

[Feature] make an import private key option when we install aleo web extension

Closing this issue, as it is not relevant to snarkVM.

[Proposal] Finalize cost should not include commands skipped by `branch` command

Great observation! We are in the process of determining the fee model for finalize, in the current form, we are checking that you pay for the entirety of the finalize...

[Proposal] Finalize cost should not include commands skipped by `branch` command

Yes, at the moment we do not have a concept of "refunds" with the fee transition, because the fee transition must be constructed prior to broadcasting the transaction. For privacy...

[Feature] Need a way to NOT change REST port number when --dev parameter is specified

Should be resolved with https://github.com/AleoNet/snarkOS/pull/3271

Store batch proposal to disk on shutdown

The file path should definitely be differentiated by dev_mode and network ID. Especially in the case of local devnets being run. In addition, `snarkos clean` should also remove these files.

Store batch proposal to disk on shutdown

This logic may need to be more comprehensive: Given a scenario where the latest block is at round 50: 1. A node shuts down and stores its proposal at round...