Raymond Chu

Results 114 comments of Raymond Chu

Thanks for bringing this up @elderhammer, I believe that this is something we should address, and should in theory be fairly straightforward to do so. The changes should resolve https://github.com/AleoNet/snarkOS/issues/3315....

@ljedrz @niklaslong May be better if you guys tackle the cache updates. We may also want to consider if we can unify the caches down the line.

Is this still relevant/landable now that upgradability already landed? The changes here will break circuits, so all VKs will need to be resampled for programs with constructors.

@vicsn Sorry, had to dismiss your review. I added an additional check to keep the same functionality as before the change.

@vicsn Is this PR still relevant?

What is the intention of this PR? Please provide a description.

On the `MAX_TRANSACTIONS` front, there are 2 limiters: 1. The protocol limit allows up to `2^20` transactions according to our merkle tree standard. 2. The BFT worst case scenario formula...

Should be addressed with https://github.com/AleoNet/snarkOS/pull/3422. (This PR bans peers who frequently reach timeouts)

I would agree with @vicsn that we should take option 3 seriously. IMO Option 1 should still be done, but just the existence of a ban-list enforces to malicious parties...

Same issue as https://github.com/AleoNet/snarkOS/issues/3113. Likely an issue with the networks not being up and running or the bootstrap nodes being down. Please try again on the latest snarkOS version and...