Kalyan R comments

Results 90 comments of


                                            Kalyan R

#351 - Add support for ML-Common's stats API

@dhrubo-os , were you able to find examples for the request body that can be sent to stats api?

#351 - Add support for ML-Common's stats API

> Add test? > > Integration test failing. updated it

fix: use `sqlalchemy_url` property in `get_uri` for postgresql provider

@Taragolis , all tests passed. can this be merged?

Transition to pyproject

@bilal-aamer , can you mark this PR as draft? Since, its a work in progress?

Transition to pyproject

> Kindly guide me on the next steps. I am sorry. I assumed you were still working on this. Do you have any specific doubts or issues you are facing?

Transition to pyproject

> Yes, I'm looking for some assistance on the next steps and/or resources to complete this draft PR Assuming you are looking for background knowledge, I would suggest you to...

Add dynamic setting for disk circuit breaker

@ylwu-amzn , what should be the min and max value for the threshold? Please consider giving the linked PR a quick review NOTE: I am not working on this issue...

feat: Make License mandatory for plugins submitted to meltanohub

Also, all the ones that are currently default.. if they don't have a license.. we should probably remove them as default. And also include a note about missing license.. if...

feat: Make License mandatory for plugins submitted to meltanohub

Just wondering, is it ok to update meltanohub repo's Github actions' with a task to checkout the repo and check if the license file exists? and if not.. fail it?

use `sqlqlchemy_url` property in `get_uri` for `mssql` provider

I am not working on this PR anymore. Closing the PR.