Kalyan R

Results 90 comments of Kalyan R

The only reason I raised it as a Draft PR was that I _KNEW_ that variable name was bad 😄 . I'll use `MELTANO_SYS_DIR_ROOT` and update the code. Also, do...

I'm a bit stuck on how to correct `settings.yml`. If we want to use `$MELTANO_SYS_DIR_ROOT` as a replacement to `.meltano`, what do I update the following to? ``` - name:...

> @rawwar with the changes I suggested, the default dot meltano dir would live in `/.meltano`, so the default sqlite db would still live in `sqlite:////.meltano/meltano.db` But, From the above...

Correct me If I am wrong. so, if we keep default as the following ``` - name: database_uri value: sqlite:///$MELTANO_SYS_DIR_ROOT/meltano.db env_specific: true ``` when user sets `$MELTANO_PROJECT_ROOT` to `/home/my_project` and...

I just realized while trying to write tests for #6627 that I need to write tests for this as well. I might take a while for writing tests.

> Requesting additions for the docs. Sure. I'll update the documentation today.

> https://docs.meltano.com/concepts/project#meltano-directory. @edgarrmondragon , wondering if I should update all references to `.meltano` directory to `$MELTANO_SYS_DIR_ROOT` or just mention about how `.meltano` path can be overridden using `$MELTANO_SYS_DIR_ROOT`

While updating documentation, I asked myself few things. if user selects a temporary path(probably non-persistent) for `$MELTANO_SYS_DIR_ROOT` , he can no longer user the project properly as `meltano.db` will unavailable....

> Adding it as an attribute to `meltano.core.meltano_file.MeltanoFile`. This is the simplest approach and probably good enough. I'll go with this implementation. Thank you. So, I looked into `MeltanoFile` class....

> @rawwar I think it makes sense for the `$MELTANO_SYS_DIR_ROOT ` to take precedence if it's present in the environment. Wdyt? I have been trying to implement this. Was having...