Rupert Rawnsley

Results 45 comments of Rupert Rawnsley

> I've implemented this in my client earlier this week (https://github.com/mozilla/hubs/pull/5463/files). > > The only pitfall is jsonschema version in hubs is stale thus not support RegExp construction with unicode...

> Hello, I'll guide this issue. > > 1. You must set `fontUrl.default` in `troika-text.js` > > * https://github.com/belivvr/hubs/blob/113dfa307e8f75376860ccccb5ca4e9b09e14864/src/components/troika-text.js#L65 > 2. Find `a-z` and add `가-힣` in regexp > >...

Relevant article that might be useful for investigating this issue: https://nolanlawson.com/2022/01/05/memory-leaks-the-forgotten-side-of-web-performance/

I can reproduce at least one significant leak. Here is [a test room](https://dev.reticulum.io/Fyy6RPc) with a single link through to another test room that contains a large model. This room then...

I did try and run the bot script, but [it appears puppeteer isn't working](https://github.com/puppeteer/puppeteer/issues/6622) currently on M1 Macs :-(

The first test of this on my own Hubs Cloud code isn't very encouraging and I'm still seeing apparent memory leaks. I took the (now obvious) step of just filtering...

It appears that at least one major leak was taken care of by @netpro2k during his recent refactoring. It was due to an attachment to event "camera-set-active" that was never...

@flankechen I think it was [this commit](https://github.com/mozilla/hubs/commit/5f8229a38c669a1b7053860eaf1aa5ee7e8e82c0#diff-7f28f4412d51a4907de1643b1af1acc1dc988c71a92e16ee7f69efb96cf7f189) that removes the event attachment.

I'm withdrawing this PR as the main branch has drifted significantly following the migration to bitECS, which should be inherently less leaky anyway.

@richgel999 Not OP, but we have a similar error when decoding the example files below. In our case they were generated in Blender and then processed in Adobe Lightroom. [animal_cope_01](https://github.com/richgel999/jpeg-compressor/assets/303516/7b59caca-5525-408e-8036-324c95226b87)...