Results 204 comments of Rasz_pl

and its broken completely now after reverse to broken version https://github.com/code-charity/youtube/issues/2105#issuecomment-2003966180

@ImprovedTube what was the purpose of autoplayDeniedOnce introduced in https://github.com/code-charity/youtube/commit/dc00a7e92701c83e2722c2346275a3380cc61d11 this breaks "disable Autoplay" For me the main reason for using ImproveTube is disabling autoplay :(

my comment moved from https://github.com/code-charity/youtube/pull/2109 1 We have a feature called "autoplay" 'player_autoplay' while it should be called "Disable Autoplay", https://github.com/code-charity/youtube/pull/2110 addresses this 2 ignore_autoplay_off is confusing, renaming to user_interacted...

> > #2110 > > (Still need to check if settings are false or true #1685 #2085) https://palantir.github.io/tslint/rules/no-boolean-literal-compare/ https://typescript-eslint.io/rules/no-unnecessary-boolean-literal-compare/ https://rules.sonarsource.com/java/RSPEC-1125/ https://www.c-sharpcorner.com/article/common-code-smell-mistakes-in-c-sharp-part-1/ > And ultimately, unlike for the early extension users,...

> 😆sorry @raszpl (repeated this with my head off, vaguely remembering [3cd0c66](https://github.com/code-charity/youtube/commit/3cd0c66143c14494d715bd8b38fa3f4001c6d3d7) ) This is a great example! https://github.com/code-charity/youtube/commit/3cd0c66143c14494d715bd8b38fa3f4001c6d3d7 We need player_60fps === false here because we were relying on...

> https://github.com/code-charity/youtube/blob/b412f2dde393dc18e9a3e415ef1e74815ba14984/js%26css/web-accessible/www.youtube.com/player.js#L18 > > > I can see multiple "autoplay:off - should we pause here again?" in console log, this is to blame. > This broke it [dc00a7e](https://github.com/code-charity/youtube/commit/dc00a7e92701c83e2722c2346275a3380cc61d11) > "fixes...

and there it is! ``` 16:34:31.029 functions.js:448 mousedown listener 16:34:31.029 functions.js:450 mousedown in player 16:34:31.110 player.js:26 Pause in settimeout ``` my instrumented mousedown handler: ``` ImprovedTube.onmousedown = function (event) {...

>working just fine with the "Player > Force Autoplay Off" option enabled but just now it randomly stopped working and the videos start paused wait, `"Force Autoplay Off" option enabled`...

Next time this happen open console and copy all the errors please. Something is most likely crashing.

Nothing is crashing, but there is 10 video Pause events in the first screenshot. Having recently looked at shortcut code its possible it is overriding `ImprovedTube.onkeydown` thus not running `ImprovedTube.user_interacted...