Rasz_pl
Rasz_pl
> (Underscores are considered overhead by a majority of JS developers.) > answer based on google trends!?!?! Everything is overhead when performance is considered, but here we shouldnt care about...
>Humans count/quantify work. If a project will be X% shorter, without decreasing readbility, then editors will be Y% faster & happier. Do you have any links/references to literature on this...
> Seems consistent. > (As of now our code is using camelCase which is popular among [JS-]developers) > (except for the GUI values, which might appear to users - if...
I rewrote and fixed up blocklist https://github.com/code-charity/youtube/pull/2098 https://github.com/raszpl/YouTube-Extension/tree/BLOCKLIST in theory its ready to be merged, I just didnt get around to testing it too extensively.
No native support available, but this is how example (blocked content is some of my favorite, its just for a test) data looks like: JSON.stringify(ImprovedTube.storage.blocklist) `{"channels":{"mustie1":{"preview":"https://yt3.googleusercontent.com/ytc/AIdro_lvexMnv3YQ3w6GC5tAJgH3rougPNODCB7BLMwTc99UWA=s900-c-k-c0x00ffffff-no-rj","title":"Mustie1"}},"videos":{"AEm-2giH_zw":{"title":"Flash photography used to be...
> block button no longer appears anywhere onsite after this. you dont see those ?  
partial fix https://github.com/code-charity/youtube/pull/2356 its caused by extension spamming discarded tabs and tabs it has no permissions for
**partially**, bad behavior is still there `1860 Uncaught (in promise) Error: Could not establish connection. Receiving end does not exist.` FOCUS/BLUR still needs fixing
this is why it doesnt work: https://github.com/code-charity/youtube/blob/26eb6078f2cd0193ececacc40be45cb69138c2ac/js%26css/web-accessible/www.youtube.com/player.js#L87-L209 its a jungle, last time I was here it was 1/6 the size and still required fixing https://github.com/code-charity/youtube/pull/1729
https://github.com/code-charity/youtube/blob/96879c6e2ce0321d68b1a27f36251c9a92beba44/js%26css/web-accessible/init.js#L68 this **never** executes because its being called before storage loads. This is when you broke it https://github.com/code-charity/youtube/commit/c7695ffae8bbb0c81c78e64143d5534c6091c8c2#r142127013 This mutation observer listens (well, listened until you broke it :P) to...