Ranieri Althoff

Results 385 comments of Ranieri Althoff

> nice, can we keep tab for indentation just to keep aligned with the other files? It was formatted with luaformatter, I don't know why it used spaces but maybe...

> nice, can we keep tab for indentation just to keep aligned with the other files? All files use spaces rather than tabs, are you sure about that? :thinking:

We can make loading not fail if XML is not present and drop the file altogether

> I we wont drop support for xml i preffer to keep this file with some samples (like revscript examples) The goal is to drop XML

> Droping XML support will break backward compatibility. > As far as i know TFS want to be backward compat. It won't, we can supply a XML parser written in...

Why tho? Is this needed for some other project to embed TFS, or is it just another build system that will fade into darkness like vcxproj?

> edit: I think changing int_fast32_t, ect is the problem. FP math is orders of magnitude slower than integer math. I don't see why you changed the `get*Cost` functions to...

> I don't understand why someone would want to have ninja handling the build for them on windows if they are using visual studio to develop. This PR is doing...

> to what extent is it good to use namespace to handle all singletons? Singletons are ~almost~ always a bad idea. Namespaces are an enhanced `private` section in a class,...

@jo3bingham I guess this decision taking (following target) is checked every "tick" of the scheduler, which is 1000ms, that's why if you leave just after this 1000ms started, the creature...