Ranieri Althoff comments

Results 385 comments of


                                            Ranieri Althoff

Overloading addTask func

Btw needs formatting, please run `make format`

fix warnings caused in 4022

I said this in private, I suspect this just hides the warnings and does not fix the root of the problem (huge amounts of actual narrowing issues)

Use string views to avoid copying strings

Any server owner with a relatively large server willing to try and share the results? Can't properly measure with local benchmarks :sweat_smile:

Use string views to avoid copying strings

@yamaken93 this is a good idea in general, but I would be careful not to overuse it

Added Creature:onChangeZone event

Can this be achieved with a regular `onWalk` callback?

Added Creature:onChangeZone event

> It can be done using onStepIn movement but you'd have to register every itemid, actionid or w/e u'll be using and check if a creature is changing zone... but...

Replace virtual functions with static_cast

You'll need to rebase and reformat the files

Replace virtual functions with static_cast

> what is the context for this pull request? performance gain? resolving potential crashes? code cleanup? It saves one virtual function call - which cannot be inlined because the function...

uxMode='redirect' does not redirect and opens a popup

Same problem, and it seems that offline access type does not work at all with popup. So it does not work anyhow.

Support Node 14's native ES module imports

I think the packages export all that's needed for both module and commonjs imports, so omitting `type` should suffice