forgottenserver icon indicating copy to clipboard operation
forgottenserver copied to clipboard

fix warnings caused in 4022

Open Zbizu opened this issue 4 years ago • 2 comments

Pull Request Prelude

Changes Proposed

revert moving cryptopp/rsa.h (solves most if not all warnings during compilation)

Issues addressed: warnings after #4022

Zbizu avatar Apr 04 '22 02:04 Zbizu

I see many other warnings unrelated to this. Can you post some warnings this supposedly fixes?

Compilation logs (on 1c9297a) available here: https://gist.github.com/Zbizu/b39e5a759530b21e983bfb89a2b7b002

Reproduction Environment

OS: Windows 10 Home 21H2 (19044.1586) IDE: visual studio 2022 (version 17.0.4) .NET Framework 4.8.04084 Toolset: v143 SDK: 10.0 C++ standard: ISO C++ 17 (/std:c++17) Configuration: release x64 CPU: i5-3570K

Context

Some days ago I've cloned most recent tfs and got a lot of warnings. After narrowing down to the commit that have caused that I've opened an issue #4028

Later I've been updating my customized branch with upstream commits. Once I reached #4022, I started investigating it and moving files in groups (with compilations between moves) and discovered that moving this file was the cause of all warnings.

The branch in which I have customized stuff compiles without any warnings in visual studio. All I did was not moving that cryptopp file. I didn't add anything from Mar 22 onwards.

Zbizu avatar Apr 06 '22 04:04 Zbizu

I said this in private, I suspect this just hides the warnings and does not fix the root of the problem (huge amounts of actual narrowing issues)

ranisalt avatar Apr 06 '22 11:04 ranisalt

Closing as no one seem to care anymore. If anyone need this, it will remain referenced in 4022 itself.

Zbizu avatar Aug 25 '22 15:08 Zbizu