Ben Ramsey comments

Results 295 comments of


                                            Ben Ramsey

Add support for PKCE (Proof Key for Code Exchange [RFC 7636])

I will try to tag a release in the next week.

Allow time to be fetched from a universal clock ⏱

> Add a `public getClock` method? Per above I don't see a valid rationale, yet. IMO, the rationale for a `getClock()` method is in your purpose statement for this: >...

[Proposal] Add locked-down peer verification for each provider

The 1.0 branch is already running Guzzle 5. :-)

[Proposal] Add locked-down peer verification for each provider

Ping @enygma and @ircmaxell. We'd like your security advice, please. See above thread. :-)

[Proposal] Add locked-down peer verification for each provider

@SammyK, can you give me the TLDR of this thread? Should it remain open? Is there work to be done?

[Proposal] Add locked-down peer verification for each provider

Thanks. Removing the v1.0 milestone, but I'll keep it open.

[Proposal] Add locked-down peer verification for each provider

@SammyK @shadowhand @enygma Thoughts on putting peer verification into a separate package that interested providers could require to add the functionality to their implementations?

Set custom User-Agent for requests

Possibly related to or solved through #863

Adding oauth2-firefly-iii client

Please include a license file in your repository so that it's clear to users what terms you are granting them. I see "MIT" listed in `composer.json`, but an explicit license...

Recommended package stevenmaguire/oauth2-microsoft seems abandoned

If @stevenmaguire is no longer maintaining `stevenmaguire/oauth2-microsoft`, he can archive his repo and mark the package as abandoned then submit a PR to remove it from [docs/providers/thirdparty.md](https://github.com/thephpleague/oauth2-client/blob/master/docs/providers/thirdparty.md). However, it sounds...