David Ramos

Results 148 comments of David Ramos

Here's a visual illustration of the issue from a Honeycomb trace: Notice the delay of about 17s following the final attempt (which returned `Error::Permanent`). The timing bar at the top...

most of the openidconnect crate's tests are related to serialization and deserialization. there was a test suite that used the public OpenID Connect [conformance tests](https://openid.net/certification/rp_testing/) previously, but that testing system...

> I'd expect such a disclaimer in the _CSP_ documentation - disabling eval on the page is highly likely to break third-party code, and as such, should be carefully considered...

Closing due to inactivity.

This should no longer be an issue in recent releases. Please feel free to reopen if that's not the case.

I'll try to find some time to review PRs related to this effort. I'm fine with removing `ring` entirely rather than adding RustCrypto behind a feature flag and maintaining both...

I think the root cause of this issue is that if an argument is passed to `--unit-test`, the `kind` value passed to `build()` is an empty vec: https://github.com/flamegraph-rs/flamegraph/blob/c532c046b171952f8812dd76b09298c0c558bf8d/src/bin/cargo-flamegraph.rs#L406 The `build()`...

> > The `AC` (additional claims) type parameter for the [`Client`](https://docs.rs/openidconnect/1.0.1/openidconnect/struct.Client.html) struct specifies the type of the additional claims. To receive custom claims, I recommend defining your own type alias...

Crossposting from [`ramosbugs/oauth2-rs#177`](https://github.com/ramosbugs/oauth2-rs/issues/177#issuecomment-1363367950): > The `openidconnect` crate is open for breaking changes again due to needing to bump its MSRV to 1.57, and I think this would be a good...