David Ramos
David Ramos
hey @jeroenvervaeke, this brings up an interesting API design issue that I've struggled with a few times in the past. you're correct that the authorization endpoint isn't required for the...
hey @ximon18, it's not clear to me what the status of the errata on that site are, and whether there's any sort of formalized approval process. I think it would...
> The status is that the errata has not yet been accepted. However, in this particular case the "missing" fields are actually already in the rfc elsewhere but still not,...
it looks like I pinned to this version awhile back in 5042753669f5357473460bfbed42742d57e26480 in order to continue supporting any version of Rust >= 1.34.0. Newer versions of `unicode-normalization` don't compile with...
Hey, thanks for filing this issue. I pushed a patch in the new 2.3.2 release to make the error message clearer by printing the raw issuer URL that's involved in...
I think the current validation should work; clients just need to be sure that the issuer URL they provide exactly matches the one that the OIDC provider returns in its...
hey, thanks for the PR! it looks like this will make pretty substantial breaking changes to the public API (e.g., [`IdTokenClaims::expiration`](https://docs.rs/openidconnect/2.3.1/openidconnect/struct.IdTokenClaims.html#method.expiration)) and also increase the MSRV (I think to 1.50?)....
hi @sbihel, thanks for the PR! Given some other challenges around ring (e.g., mixed versions within a single binary crate), I'd definitely be in favor of removing the dependency, or...
> I am currently trying to get this working. However, there is one issue with that PR. When any other crate pulls in `ring` too, this will automatically enable all...
now that I merged #69, mind rebasing and force pushing (or merging `main` back into this branch)? that should make it easier to review