David Ramos

Results 148 comments of David Ramos

> Also, I think we should add support for the `sid` claim in the `IdToken` too (even tho this would be already possible with the additional claims support). The backchannel...

> @ramosbugs would you mind linking #70 (or the corresponding branch) to this issue? Sure, I think just referencing it in the PR message accomplishes that

this seems like a reasonable enhancement to this crate, although the standard looks like it's still in a draft state: https://datatracker.ietf.org/doc/html/draft-ietf-oauth-dpop-04. are there any major OpenID Connect providers using this...

This sounds like a reasonable change, but I wonder if there would be a way to put it behind a Cargo feature flag to avoid introducing a breaking change. Otherwise,...

I'd definitely welcome PRs to address any gaps in the examples. > I myself would love to see examples of how to define your own additional claims. I've gotten so...

Hey, great question! You're correct that this crate doesn't implement any caching functionality. Since OIDC Discovery relies on HTTP headers for its caching functionality, it feels like the caching is...

React [Strict Mode](https://reactjs.org/docs/strict-mode.html) complains about this now: ``` Warning: Using UNSAFE_componentWillReceiveProps in strict mode is not recommended and may indicate bugs in your code. See https://reactjs.org/link/unsafe-component-lifecycles for details. * Move...

> This seems to have started working unannounced, at least when using docker 20.10.11 to build I'm still seeing `error writing manifest blob` with `400 Bad Request` on Docker `5:20.10.12~3-0~ubuntu-focal`,...

just want to start off by saying this is one of my favorite crates and makes it a lot easier to write functional Rust! that said, I have made this...

I see this is addressed in #139 :-) ~~looks like clippy is unhappy about `self: Self` in a bunch of (existing) places:~~ ``` error: the type of the `self` parameter...