Rafi Shamim

We might need to update the syntax rule for collation names here: https://github.com/cockroachdb/cockroach/blob/c1828e71175a0406380c8295ec23cd71d295621d/pkg/sql/parser/sql.y#L16721

I was able to repro with this smaller testdata file: ``` statement ok CREATE TABLE t (k INT PRIMARY KEY, v int, FAMILY (k, v)) statement ok GRANT admin TO...

I was able to reproduce this on 9203985b8ee0092cc9ba1f517cb5f1306f07e2ff as well, which is the parent commit of 25edb96894f9c4654c4bb52477b9887cf8a13150. I'm starting another bisect to find the first failing commit.

This fails all the way back to d93923b15ecccbbf6975a9b5cc4c2ed050e324a6 from over a year ago (I still haven't found the first failing commit), so it does seem likely to be https://github.com/cockroachdb/cockroach/issues/121917, and...

My repro with the example above in `pkg/sql/logictest/testdata/logic_test/_tmp` running with `./dev test ./pkg/sql/logictest/tests/local -f=TestLogic_tmp --stress --count=1000` fails just as quickly before or after 25edb96.

It appears that n2 failed to ever startup, due to connectivity issues in the cluster ``` W240510 13:59:49.014602 15 gossip/client.go:121 ⋮ [T1,Vsystem,n2] 48 failed to start gossip client to ‹40.76.187.244:26257›:...

nice work! looks like there's one issue in the new test. ``` === RUN TestDoctorClusterDropped/examine [debug --host=127.0.0.1:39133 --insecure=false --certs-dir=/var/lib/engflow/worker/work/0/exec/_tmp/1855398a359288315eef18ccd1f2c1dd/cli-test2994948257 doctor examine cluster] datadriven.go:144: /var/lib/engflow/worker/work/0/exec/bazel-out/k8-fastbuild/bin/pkg/cli/cli_test_/cli_test.runfiles/com_github_cockroachdb_cockroach/pkg/cli/testdata/doctor/test_examine_cluster_dropped:1: expected: debug doctor examine cluster Examining...

cc @vy-ton -- should we just log a warning/notice if we ever see an index where the first column is a timestamp? a little section in the web UI that...

I agree to starting with adding this warning when a column has `DEFAULT current_timestamp()` and it appears as the first column in an index (either primary or secondary). I'll update...

This might be fallout from https://github.com/cockroachdb/cockroach/pull/124580. if you feel like it is, feel free to re-assign to me if you'd like.