Rafi Shamim
Rafi Shamim
Let's make the assertion more than 10 seconds; we'll try 20 seconds first. @Dedej-Bergin could you do that as part of secondary on-call?
Checking if KV has any ideas on this. The assertion that failed is https://github.com/cockroachdb/cockroach/blob/3962ffca4feb71db0f66e8f71495d66ba986c1d8/pkg/ccl/multiregionccl/roundtrips_test.go#L130-L132 Somehow `entry.ClosedTimestampPolicy` is `-1`, which is not even a valid enum value. I'm not sure how...
That is surprising. Could we try adding even more logs, like this? https://github.com/cockroachdb/cockroach/pull/133688 I wonder if this means the server never received the connection at all.
The latest failure has additional debug logs present. The last debug log we see is: ``` I241112 21:42:24.157507 8266 sql/pgwire/pre_serve.go:459 ⋮ [T1,n1,client=‹@›] 246 client did not request SSL version=196608 AcceptSQLWithoutTLS=false...
Unfortunately, replacing the `lib/pq` library everywhere in our code/tests would be an enormous project. For the past couple years we have been changing specific use cases to using `pgx`, but...
> do you think it makes sense to cherry-pick that commit into this PR? yes, let's do it this way. thanks!
While we're documenting this, we may want to clarify that our `transaction_timeout` differs from Postgres. Ours causes the transaction to abort, but Postgres' causes the session to terminate. (Postgres added...
That may be a question for @dikshant -- is it OK to not show the full explanation back to the user as long as the full explanation is included in...
> I will review the failed tests later. Thanks, but no need. There's a known issue with that failing job, which is why it's not marked as "Required."
``` COMMAND_PROBLEM: exit status 134, , E241015 07:00:04.702475 1 1@util/log/logcrash/crash_reporting.go:192 [-] 1 a panic has occurred! (1) attached stack trace -- stack trace: | github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests.validateCorpusFile | github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests/mixed_version_decl_schemachange_compat.go:97 | github.com/cockroachdb/cockroach/pkg/cmd/roachtest/tests.runDeclSchemaChangeCompatMixedVersions.func2 |...