Rafi Shamim comments

Results 148 comments of


                                            Rafi Shamim

feat: Add Cockroachdb support without transactions

@WikiRik Hi! CockroachDB developer here - do you know if this PR is able to get reviewed?

sql: partial predicate evaluation fails for newly added columns

this actually is blocked now in the legacy schema changer, so i will close this out ``` root@localhost:26257/defaultdb> create table t (i int primary key); -> ; CREATE TABLE Time:...

Unsupported query: unsupported binary operator: <int> / <int> (desired <int>)

I don't think this could be addressed by automatically typecasting, since I don't think we'd add logic that could make the result lose precision without the user intending it. So...

Add ability to wrap an error with an Unimplemented error

> ``` > return nil, errors.Wrapf( > unimplemented.Newf("import.mysql.default", "unsupported default expression"), > "error parsing expression %q for column %q (%v)",` exprString, name, err /* XX lint exclusion */) > ```...

PR #42063 - sql: new session variable `strict_ddl_atomicity`

> I think CREATE ROLE, CREATE USER, and GRANT are all DDL statements - @rafiss is that correct? that's correct

Add support for all native data types

Additionally, I noticed some array types are missing: - `_char` (OID: 1002 -- this is the array type for QChar aka `"char"`) - `_name` (OID: 1003) - `_timetz` (OID: 1270)

pgwire: log session start and end unconditionally

thanks for the review! bors r+

performance of UUID generation is slow – implementation uses `getrandom` syscall

> there might be wrong assumptions in the code which assume that the underlying implementation of uuid.MakeV4() will produce zero collisions. We actually intentionally assume collision free UUIDs in some...

performance of UUID generation is slow – implementation uses `getrandom` syscall

Also note that for PG compat, we may need to keep UUID generation through SQL as cryptographically secure https://security.stackexchange.com/questions/93902/is-postgress-uuid-generate-v4-securely-random/93905#93905

performance of UUID generation is slow – implementation uses `getrandom` syscall

We can make a cluster setting that determines which random source to use for `gen_random_uuid`.