Ankit Jain

Results 267 comments of Ankit Jain

We can drop the changes in `TestingAppHost1`, but then we need to add a test somewhere else. I did try adding `Keycloak` playground app to the tests for which `/alive`,...

Looks like `WithBindMount` does not expect the path to exist. And `ContainerMountAnnotation` even allows a null source path. https://github.com/dotnet/aspire/blob/ac3dbc4e0d6982ebf69b980789f9b06a90ed63c1/src/Aspire.Hosting/ApplicationModel/ContainerMountAnnotation.cs#L18-L19 I'll restore the check, and expand the path using the apphost...

Merge after https://github.com/dotnet/aspire/pull/5276 .

Related to https://github.com/dotnet/aspire/issues/4623 .

These tests have been disabled with https://github.com/dotnet/aspire/pull/4922 . Closing, this in favor of the original issue.

Re-opening because https://github.com/dotnet/aspire/issues/4623#issuecomment-2231591055 .

This is not a flaky test. We don't have Playwright installed on Linux/helix, so these tests don't run there. But we run the same on github actions/ubuntu-latest.