r0qs

Results 76 comments of r0qs

Hahaha, thanks @gnidan! It works indeed, but the correct method is: ```javascript await c.methods["write(string)"]("One", { from: account }); ``` Since is the method with signature "write(string)" that looks to be...

> > The binary is not completely static. Z3 is actually the one thing we link dynamically and the `z3` package contains that dynamic library. You need it to be...

> > The changes look good to me now, we just need to squash the commits. I was also wondering if we could merge the changes proposed in this PR:...

I agree with @matheusaaguiar's comments about using `ranges::find_if` and doing the comparison directly (i.e. removing `containPrefixingToken` function) . To give you some directions about the tests, you will need to...

It seems that if the directory is defined as: `node_modules/` or `./node_modules/` (with the forward slash in the end). The orb will not ignore it. If I change it to:...

We also need to update the build scripts, like [build.sh](https://github.com/ethereum/solidity/blob/develop/scripts/build.sh). But I'm wondering why not just add the `git submodule update --init` in the [CI build script](https://github.com/ethereum/solidity/blob/develop/scripts/ci/build.sh) and consequently all...

Actually, maybe even better, I think we could do all in cmake using [execute_process](https://cmake.org/cmake/help/latest/command/execute_process.html), something like: ```cmake find_package(Git) if(Git_FOUND) execute_process(COMMAND git submodule update --init ...) ... endif() ``` And also...

Thanks @ToonVanHove, I'm already approving, but please remove the trailing whitespace as reported here: https://app.circleci.com/pipelines/github/ethereum/solidity/34603/workflows/0f99fcfa-1229-432c-9a19-d59a9ac4b4bb/jobs/1568548

Please, also rebase and squash the commits ;)

Thanks @KillariDev but for now we decided to not lock the dependencies. So I'm closing this ;)