shellcheck-orb icon indicating copy to clipboard operation
shellcheck-orb copied to clipboard

Orb parsing directories that should be ignored

Open r0qs opened this issue 3 years ago • 1 comments

Orb version: 3.1.1

What happened:

Hi, I configured the orb to ignore the following folders:

      - shellcheck/check:
          ignore-dirs: |
            .git/
            node_modules/
            dist/

However, the logs show that the directories were considered:

./node_modules/foreground-child/changelog.sh
./node_modules/tape/example/static/build.sh
No ShellCheck Errors Found

Even if I specify with the current directory prefix (e.g. ./node_modules/).

Expected behavior:

I would expect that the orb would ignore those directories. ~Or do the logs only mean that the orb found those shell script files but did nothing with them?~

r0qs avatar Sep 28 '22 10:09 r0qs

It seems that if the directory is defined as: node_modules/ or ./node_modules/ (with the forward slash in the end). The orb will not ignore it. If I change it to:

     - shellcheck/check:
          ignore-dirs: |
            ./.git
            ./node_modules
            ./dist

It works as expected.

r0qs avatar Sep 28 '22 10:09 r0qs

the orb is already adding that extra slash in the end when passing the exceptions to the command, so when you add it, it gets a double slash. I will add an specification about not adding the slash at the end.

marboledacci avatar Mar 05 '25 15:03 marboledacci